Skip to content

Update add-ssh-key-to-ssh-agent documentation#1074

Merged
shati-patel merged 3 commits intogithub:mainfrom
GuillaumeBAECHLER:patch-1
Nov 20, 2020
Merged

Update add-ssh-key-to-ssh-agent documentation#1074
shati-patel merged 3 commits intogithub:mainfrom
GuillaumeBAECHLER:patch-1

Conversation

@GuillaumeBAECHLER
Copy link
Contributor

@GuillaumeBAECHLER GuillaumeBAECHLER commented Nov 4, 2020 •
edited
Loading

Why:

Update the add-ssh-key-to-ssh-agent documentation with the new key generation algorithm used in ssh key creation step (ed25519)

What's being changed:

Replaced id_rsa with id_ed25519 in :

  • data/reusables/ssh/add-ssh-key-to-ssh-agent-commandline.md
  • data/reusables/ssh/add-ssh-key-to-ssh-agent.md

Check off the following:

@welcome
Copy link

welcome bot commented Nov 4, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

This was referenced Nov 5, 2020
Closed
Closed
@janiceilene
Copy link
Contributor

janiceilene commented Nov 6, 2020

👋 @GuillaumeBAECHLER Thank you so much for opening a PR! Some of the updates in this PR are already being addressed in #1063. Would you mind removing the duplication? 💖

@GuillaumeBAECHLER
Copy link
Contributor Author

GuillaumeBAECHLER commented Nov 7, 2020

Hi @janiceilene ! Can't find any duplication in the linked PR, the files concerned are not the same. Btw, I find there are a lot of PRs for this topic now. So we can close this PR if you want to address all changes linked to ed25519 documentation in a single one. 😄

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 14, 2020
@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core and removed stale There is no recent activity on this issue or pull request labels Nov 16, 2020
@shati-patel shati-patel self-assigned this Nov 20, 2020
shati-patel
shati-patel approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request @GuillaumeBAECHLER!

To come back to this:

Can't find any duplication in the linked PR, the files concerned are not the same. Btw, I find there are a lot of PRs for this topic now. So we can close this PR if you want to address all changes linked to ed25519 documentation in a single one. 😄

You're right, there are quite a few similar PRs 😅 I'm working my way through them in reverse chronological order. Yours is one of the first, so I'll merge this and close any later duplicates 🎉

@shati-patel shati-patel merged commit 326897a into github:main Nov 20, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@GuillaumeBAECHLER GuillaumeBAECHLER deleted the patch-1 branch November 2, 2021 08:45
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Rajakavitha1 @lukas-bernert @Loquacity
[update] Modify basic parameters (github#1074)
de1cd22 
* added a note about the plans

* Update cloud/service-settings/customize-configuration.md

Co-authored-by: Lukas Bernert <lukas@bernert.at>

Co-authored-by: Lukas Bernert <lukas@bernert.at>
Co-authored-by: Lana Brindley <github@lanabrindley.com>
@Chantall1602 Chantall1602 mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shati-patel shati-patel shati-patel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shati-patel shati-patel

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeBAECHLER @janiceilene @shati-patel